Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ryan's dedicated VM #183

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

kysrpex
Copy link
Contributor

@kysrpex kysrpex commented Dec 8, 2023

We agreed that this VM can be cleaned up, so let's remove it.

We agreed that this VM can be cleaned up, so let's remove it.
@kysrpex kysrpex self-assigned this Dec 8, 2023
@bgruening
Copy link
Member

Can one of the admins verify this patch?

@kysrpex kysrpex marked this pull request as ready for review December 8, 2023 15:53
@kysrpex kysrpex mentioned this pull request Dec 8, 2023
@mira-miracoli
Copy link
Contributor

I wonder why @usegalaxy-eu-bot did not comment with the terraform plan

@kysrpex
Copy link
Contributor Author

kysrpex commented Dec 11, 2023

I wonder why @usegalaxy-eu-bot did not comment with the terraform plan

I made a draft first that's why, I think. I did not want to make noise before the bot ran. I achieved the opposite effect.

I'll take care of this or do what the bot does myself as a sanity check and post it here.

@kysrpex kysrpex removed the request for review from sanjaysrikakulam December 11, 2023 14:39
@mira-miracoli
Copy link
Contributor

I mean it should be simple in this case, but good that you noted this with the draft, I wouldn't have thought about that either

@sanjaysrikakulam
Copy link
Member

I wonder why @usegalaxy-eu-bot did not comment with the terraform plan

I made a draft first that's why, I think. I did not want to make noise before the bot ran. I achieved the opposite effect.

I'll take care of this or do what the bot does myself as a sanity check and post it here.

The bot did not run because the PR branch is not internal. For the bot to work, the PRs must come from an internal branch of this repo.

@sanjaysrikakulam sanjaysrikakulam merged commit 83f32b3 into usegalaxy-eu:main Jan 4, 2024
1 check passed
@bgruening
Copy link
Member

That makes a lot of sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants