-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GxIT subdomains #178
Add GxIT subdomains #178
Conversation
This PR matches the current state of IT subdomains in AWS Route 53.
@hexylena can you please have a look at this one? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but wait for @hexylena's review too.
@bgruening I can look, and on the surface it looks fine (though I still maintain my position on this solution vs path-based.) I do wonder how it will be kept in sync with the ansible variable(s) that requests wildcards for only those, but maybe fetching this file from github via some automation, or during the ansible run, or, some other solution can be found for that. |
We all do. But we also need to move forward until this gets implemented/tested because our users needs it as it seems. Thanks for looking into it! |
|
This PR matches the current state of IT subdomains in AWS Route 53.
I have cross-checked the current wildcard IT CNAME records list in our AWS Route53 and added a new variable. So, in the future, if a subdomain requests GxIT privileges, we can simply add that subdomain to this variable and increase the counter. This way, we do not allow GxITs for all subdomains by default (hence a new exclusive variable).