Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new interactive tool urls #1769

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

cat-bro
Copy link
Collaborator

@cat-bro cat-bro commented Feb 8, 2024

Since updating dev to release_23.2 interactive tools are being mapped to < some uuid >.ep.interactivetool.dev.gvl.org.au instead of < some uuid >.interactivetoolentrypoint.interactivetool.dev.gvl.org.au. After creating a new CNAME record for dev and updated the certificate to include the new pattern, ITs are working on dev. I could be missing something about how ITs are supposed to work post 23.2.

@nuwang
Copy link
Contributor

nuwang commented Feb 8, 2024

This is the commit in which the changes occurred: galaxyproject/galaxy#16795
I think your fix for this is correct. The whole <uuid>.ep.interactivetool part still seems to be a bit redundant to me, why not just <uuid>.interactivetool and avoid the extra dns lookup for the ep part? But that seems like an issue for another day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants