forked from serialport/node-serialport
-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
replace node-pre-gyp with node-gyp, remove artifacts directory-structure
- Loading branch information
Martin Schuhfuss
committed
Jun 8, 2015
1 parent
884b5f3
commit c5aace8
Showing
3 changed files
with
9 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,58 +1,26 @@ | ||
{ | ||
"name": "serialport", | ||
"name": "serialport-electron", | ||
"version": "1.7.4", | ||
"description": "Welcome your robotic javascript overlords. Better yet, program them!", | ||
"description": "Unmaintaned fork of serialport that builds with electron!", | ||
"author": { | ||
"name": "Chris Williams", | ||
"email": "[email protected]", | ||
"url": "http://www.voodootikigod.com" | ||
}, | ||
"binary": { | ||
"module_name": "serialport", | ||
"module_path": "./build/{module_name}/v{version}/{configuration}/{node_abi}-{platform}-{arch}/", | ||
"remote_path": "./{module_name}/v{version}/{configuration}/", | ||
"package_name": "{node_abi}-{platform}-{arch}.tar.gz", | ||
"host": "https://node-serialport.s3.amazonaws.com" | ||
}, | ||
"main": "./serialport", | ||
"repository": { | ||
"type": "git", | ||
"url": "git://github.com/voodootikigod/node-serialport.git" | ||
"url": "git://github.com/usefulthink/node-serialport.git" | ||
}, | ||
"maintainers": [ | ||
{ | ||
"name": "Chris Williams", | ||
"email": "[email protected]" | ||
}, | ||
{ | ||
"name": "Joe Ferner", | ||
"email": "[email protected]" | ||
}, | ||
{ | ||
"name": "Jay Beavers", | ||
"email": "[email protected]" | ||
}, | ||
{ | ||
"name": "Rob Giseburt", | ||
"email": "[email protected]" | ||
}, | ||
{ | ||
"name": "Francis Gulotta", | ||
"email": "[email protected]" | ||
} | ||
], | ||
"dependencies": { | ||
"async": "0.9.0", | ||
"bindings": "1.2.1", | ||
"debug": "^2.1.1", | ||
"nan": "~1.8.4", | ||
"node-pre-gyp": "0.6.x", | ||
"node-gyp": "^2.0.1", | ||
"optimist": "~0.6.1", | ||
"sf": "0.1.7" | ||
}, | ||
"bundledDependencies": [ | ||
"node-pre-gyp" | ||
], | ||
"devDependencies": { | ||
"mocha": "*", | ||
"chai": "*", | ||
|
@@ -72,7 +40,7 @@ | |
"serialportterm": "./bin/serialportTerminal.js" | ||
}, | ||
"scripts": { | ||
"install": "node-pre-gyp install --fallback-to-build", | ||
"install": "node-gyp rebuild", | ||
"test": "grunt --verbose" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c5aace8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked perfectly for compiling against electron (using electron-rebuild to make things easier). Is there anything left to do? Otherwise it'd be great to see this merged into serialport so it works out of the box for Electron.
c5aace8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main problem has to do with the node-pre-gyp process node-serialport is using. So merging this would result in longer install-times for everybody else. I think the best place to address this would be the node-pre-gyp project (I recall there was already an issue about it, but I didn't have the time to look further).
c5aace8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think it'd be best to wait for node-pre-gyp to support Electron compiling. In the meantime your fork is simple enough to implement whenever I need to compile changes. Thanks!
c5aace8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I got serialport to work with electron with these changes, I'm also getting full cpu usage. Are you having the same issue or is it just me?
c5aace8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not experiencing full CPU usage, but I'm not maintaining a two-way, constant connection with a device, just occasionally send data to a device
c5aace8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you post some sample code of your approach? Just by instantiating the SerialPort drains my cpu: