fix: handle case of text when invalid JSON (#3119) #3120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue where Bruno crashes when receiving non-JSON responses (like
"true"
) with theapplication/json
content type. The crash was caused by Bruno attempting to parse an invalid JSON response. The fix modifies the return data handling to prevent the crash.fix: #3119
Changes Implemented:
Modified return data handling:
safeStringifyJSON(data)
to ensure that even non-JSON responses are handled safely without causing a crash.Early return for null data:
data
isnull
, ensuring that the logic to process the response is skipped, preventing potential errors from treatingnull
as data.Removed unused parameter:
safeStringifyJSON
calls where it was set totrue
, since the function definition only expects one parameter.Testing and Validation:
"true"
are returned now no longer cause the client to crash.null
responses, are properly handled with the early return.Contribution Checklist: