Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cursor jump to start #3082

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

maxdiplogit
Copy link
Contributor

Description

Fixes: #2978

This PR fixes the cursor jumping to the start of the request URL bar when one deletes a whitespace character in the request URL bar. This was happening because the value was being trimmed every time the value was changed in the URL bar, which triggered the cursor to go to the starting. Now the request URL will only be trimmed when the request URL is being saved.

Screen.Recording.2024-09-13.at.12.mp4

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@helloanoop helloanoop merged commit 9614ab0 into usebruno:main Sep 13, 2024
@helloanoop
Copy link
Contributor

Merged! Thanks @maxdiplogit !

@pietrygamat
Copy link
Contributor

After this merge, the save button does not work:
ReferenceError: value is not defined.
Should possibly revert it or replace with #3087 ASAP.

@helloanoop
Copy link
Contributor

Thanks for the bump @pietrygamat !
I have merged #3087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor Jumps to Start Deleting Character and Space in the Request URL Bar
3 participants