Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reuse dictionary in preferences support page #2834

Conversation

iamsushantk
Copy link
Contributor

Description

We recently merged this PR to source the commonly used text from the Dictionary. This PR is about re-using the dictionary in the Preferences->Support component.

Refer the screenshots before and after the change:

Before


image

After


image

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Copy link

@Gadiffet Gadiffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@helloanoop helloanoop merged commit f0b7bf3 into usebruno:main Aug 16, 2024
2 checks passed
@helloanoop
Copy link
Contributor

Merged! Thanks @iamsushantk !

@iamsushantk iamsushantk deleted the feature/reuse-dictionary-in-preferences-support-page branch August 17, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants