Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add a show/hide privacy toggle to passwords and secrets in Auth options #2750

Merged

Conversation

nataliecarey
Copy link
Contributor

Relates to #2747

Description

User story

As a user I want my authentication password/secrets to be hidden by default and visible if I choose to reveal them.

The use case/reason

I work on a system where we have to be pretty careful with credentials, I was screen sharing with other developers while trying to make an authenticated API call from Bruno but I couldn't have the password on the screen share at any time. I ended up setting up the request without the password, disconnecting the screen share, entering the password, making the request, removing the password, starting the screen share again. I had to do that cycle multiple times which got quite frustrating.

Related PRs

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature. (note: this will be reflected better in the changed files after feat: masking support for SingleLineEditor #2240 is merged)
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Screenshots

Screenshot 2024-08-02 at 18 24 35 Screenshot 2024-08-02 at 18 24 22 Screenshot 2024-08-02 at 18 24 03 Screenshot 2024-08-02 at 18 23 45 Screenshot 2024-08-02 at 18 23 35 Screenshot 2024-08-02 at 18 23 29 Screenshot 2024-08-02 at 18 23 21

@nataliecarey nataliecarey force-pushed the feature/hide-private-auth-options branch from 4d1bb28 to 7f5ec9c Compare August 2, 2024 22:36
@helloanoop helloanoop marked this pull request as ready for review August 5, 2024 06:20
@helloanoop helloanoop merged commit c5ec7ee into usebruno:main Aug 5, 2024
3 checks passed
@helloanoop
Copy link
Contributor

Merged. Thanks for taking care of this @nataliecarey !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants