Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: draft variables and headers #2651

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

vincendep
Copy link
Contributor

@vincendep vincendep commented Jul 16, 2024

Description

This PR make sure that request headers and vars get picked up correctly when the request to be sent is in a draft state.

Closes #2627

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@lrotermund
Copy link

lrotermund commented Aug 5, 2024

Thanks @vincendep for the bug fix. @sanjai0py I'm sorry to ask, but is there any prospect of which bruno version this merge request will be released with? How long does it usually take for you to go from bug fix to release?

@helloanoop helloanoop merged commit 92073e7 into usebruno:main Aug 6, 2024
2 checks passed
@helloanoop
Copy link
Contributor

Merged! Thanks for the fix @vincendep !

@lrotermund This will be shipped in the v1.24.0 that is planned to be released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre Request vars aren't updating until the request is saved
3 participants