Import Bruno Collection fails - ValidationError: headers are required #2583 #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@helloanoop this seems like it may be a fix due to a regression introduced in PR #2560 - Should this be |
2 tasks
lohxt1
approved these changes
Jul 10, 2024
|
Merged. Thanks @sfreeman422 ! This will be released today in |
jwetzell
pushed a commit
to jwetzell/bruno
that referenced
this pull request
Aug 2, 2024
…usebruno#2583 (usebruno#2598) * Removed headers key on folderRootSchema as it seems unlikely that headers are actually required here * Removed launch.json * Added back package-locks * reverted package-lock * removed only the .required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves Issue #2583 in which Bruno Collections are not able to be imported due to validation errors on header.
This was resolved by removing the header validation check on the folderRootSchema as it seems unlkely that folderRootSchema would require headers.
Testing locally confirms that this fixes the bug.
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.