feat(#2265): Support GraphQL variables formatting #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhcorporate
approved these changes
May 8, 2024
|
Looks great! |
mheidinger
approved these changes
May 8, 2024
Eynorey
commented
Sep 2, 2024
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inspired by #526 and its follow-ups, this PR adds support for formatting code on the GraphQL Variables tab.
It equips the
CodeEditorcomponent with formatting capabilities (usingprettier) and a button that's only rendered if consumers provide theformattingOptionsprop, where an appropriate parser and potential prettier plugins can be specified.This way the formatter can be re-used in other places down the line as described in #2265.
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.