Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow translation of more postman scripts #2054

Merged
merged 1 commit into from
May 13, 2024

Conversation

lanthoor
Copy link
Contributor

Description

  1. This PR allows translation of additional Postman specific scripts.
    • pm.response.json()res.getBody()
    • pm.environment.has("xyz")bru.getEnvVar("xyz") !== undefined && bru.getEnvVar("xyz") !== null
    • pm.expect( ... )expect( ... )
  2. Tests to cover the above scenarios
  3. Fix an incorrect regex in the translation script
    • 'pm.response.to.have\\.status\\(''pm\\.response\\.to\\.have\\.status\\('

Fixes #1973

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@lanthoor
Copy link
Contributor Author

Had to close #1972 because I messed up the branch. Can we get this through please? @helloanoop @sanjai0py

@helloanoop helloanoop merged commit 4df7891 into usebruno:main May 13, 2024
3 checks passed
@BBE-91
Copy link

BBE-91 commented May 23, 2024

Great, will be very helpfull for importing collection.
So now #1909 can be closed as well ? @helloanoop

jwetzell pushed a commit to jwetzell/bruno that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow translation of additional Postman scripts
3 participants