Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to keep the default truststore, when using a custom CA (#1080) #1863

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

slowjoe007
Copy link
Contributor

@slowjoe007 slowjoe007 commented Mar 20, 2024

Description

Description

In Bruno when specifying a custom certificate authority certificate, so connections to servers using privately signed certificates can be established securely, the Node.js default truststore is discarded. Therefore, connections to systems using officially signed certificates cannot be established any more as their root CAs are no longer part of the configuration.

While you could add the official root CA certificates to the file that contains your custom CA certificate, this is a tedious job and it is more convenient to tell Bruno directly to either augment or replace the default truststore with the custom CA certificates.

Usage

No custom CA certificate in use

Therefore, default truststore is in place. No need to allow for a choice. Checkbox "Keep default CA Certificates" is disabled.
Screenshot 2024-03-19 at 20 18 47

Custom CA certificate specified

Checkbox "Keep default CA Certificates" is active, but not selected yet. Therefore, only the custom CA certificate is in use and thus the default truststore is replaced.
Screenshot 2024-03-19 at 20 19 43

Custom CA certificate augments default truststore

Checkbox "Keep default CA Certificates" is active and selected. Therefore, default truststore is augmented by the custom CA certificate. The super set of the CA certficiates is used.
Screenshot 2024-03-19 at 20 19 24

Custom CA certificate disabled

Only the default truststore is in place. Checkbox "Keep default CA Certificates" is disabled, but shows the previous selection state. This is in alignment with the file selector, which also still shows the selected custom CA certificate, although it is not in effect at the moment.
Screenshot 2024-03-19 at 20 22 28

Fixes #1080

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@slowjoe007 slowjoe007 marked this pull request as ready for review March 20, 2024 06:35
@slowjoe007 slowjoe007 changed the title Allow to keep the default truststore, when using a custom CA Allow to keep the default truststore, when using a custom CA (#1080) Mar 20, 2024
@helloanoop helloanoop merged commit 8503752 into usebruno:main Mar 22, 2024
@helloanoop
Copy link
Contributor

Merged.
This is fantastic! Thanks for the detailed PR description and screenshots.

Thanks for working on this @slowjoe007!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use system CA certificates and/or allow specifying additional CA certificates
2 participants