Allow to keep the default truststore, when using a custom CA (#1080) #1863
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description
In Bruno when specifying a custom certificate authority certificate, so connections to servers using privately signed certificates can be established securely, the Node.js default truststore is discarded. Therefore, connections to systems using officially signed certificates cannot be established any more as their root CAs are no longer part of the configuration.
While you could add the official root CA certificates to the file that contains your custom CA certificate, this is a tedious job and it is more convenient to tell Bruno directly to either augment or replace the default truststore with the custom CA certificates.
Usage
No custom CA certificate in use
Therefore, default truststore is in place. No need to allow for a choice. Checkbox "Keep default CA Certificates" is disabled.
Custom CA certificate specified
Checkbox "Keep default CA Certificates" is active, but not selected yet. Therefore, only the custom CA certificate is in use and thus the default truststore is replaced.
Custom CA certificate augments default truststore
Checkbox "Keep default CA Certificates" is active and selected. Therefore, default truststore is augmented by the custom CA certificate. The super set of the CA certficiates is used.
Custom CA certificate disabled
Only the default truststore is in place. Checkbox "Keep default CA Certificates" is disabled, but shows the previous selection state. This is in alignment with the file selector, which also still shows the selected custom CA certificate, although it is not in effect at the moment.
Fixes #1080
Contribution Checklist: