Fix #1300 : Handling request name conflicts while importing postman V2 collections #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: In Postman, multiple requests in same folder can have same name. current import code is creating bruneRequestItems with same name which is causing only one of the original requests to be actaully created. Looks like bruno doesn't allow multiple requests with same name in a given folder. Fix: Append _<duplicate_count> to conflicting request names within same folder.
aniltallam
changed the title
aniltallam
changed the title
sanjai0py
approved these changes
Mar 5, 2024
Its-treason
pushed a commit
to Its-treason/bruno
that referenced
this pull request
Sep 15, 2024
usebruno#1298) Issue: In Postman, multiple requests in same folder can have same name. current import code is creating bruneRequestItems with same name which is causing only one of the original requests to be actaully created. Looks like bruno doesn't allow multiple requests with same name in a given folder. Fix: Append _<duplicate_count> to conflicting request names within same folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue:
Fix for #1300
In Postman, multiple requests in same folder can have same name. Current importer code is creating bruneRequestItems with same name and bruno doesn't allow multiple requests with same name in a given folder. Which is causing only one of the original requests to be actually created and other requests with the same name are missing in imported collection in bruno.
Fix:
Appending "_<duplicate_count>" to conflicting request names within same folder.
Contribution Checklist: