Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: bump buildkit startup timeout to 30sec #92

Merged

Conversation

aayushshah15
Copy link

@aayushshah15 aayushshah15 commented Jan 8, 2025

Important

Increase buildkitd startup timeout to 30 seconds in setup_builder.ts.

  • Behavior:
    • Increase buildkitdTimeoutMs from 15000ms to 30000ms in setup_builder.ts to allow more time for buildkitd daemon startup.
  • Functions:
    • Affects startAndConfigureBuildkitd() by extending the wait time for buildkitd readiness.

This description was created by Ellipsis for 0e47889. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e368ff3 in 8 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/setup_builder.ts:187
  • Draft comment:
    The timeout for buildkitd startup has been increased from 15 seconds to 30 seconds. Ensure that this change is reflected in any related documentation or configuration files to maintain consistency.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the timeout for buildkitd startup from 15 seconds to 30 seconds. This change is consistent with the logic in the code, as the timeout for checking the buildkitd socket and workers is also 30 seconds. The change seems appropriate given the context.

Workflow ID: wflow_9QHd5U1Vw000MRiL


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@aayushshah15 aayushshah15 force-pushed the 01-07-src_bump_buildkit_startup_timeout_to_30sec branch from e368ff3 to 0e47889 Compare January 8, 2025 02:18
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 0e47889 in 16 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_CIzqOGLXgTBTWqE8


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@adityamaru adityamaru merged commit 3b96b27 into master Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants