Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wip): add xero connector to venice #55

Merged
merged 5 commits into from
Mar 31, 2024
Merged

Conversation

jatinsandilya
Copy link
Collaborator

Adds a xero connector to venice. Uses the auto generated SDK with from openSDKs

@jatinsandilya jatinsandilya self-assigned this Mar 30, 2024
Copy link

vercel bot commented Mar 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
venice ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2024 6:21am

Copy link

what-the-diff bot commented Mar 30, 2024

PR Summary

  • Introduction of a new connector - Xero:
    We have included a new module, connectorXero, to the list of existing connectors in our project. All related data objects and dependencies have been updated to support this integration.

  • Inclusion in different files and objects:
    The new connectorXero was added to several files for proper integration with the system. This includes addition in connectors.def.ts and connectors.merged.ts files; along with defConnectors, mergedConnectors and serverConnectors objects.

  • Metadata and Project Dependencies:
    The connector's metadata is added to the meta.js file. We've also included the new module @usevenice/connector-xero as a dependency in the package.json file for seamless integration.

  • Logo addition and new Directory:
    The logo for Xero i.e., logo-xero.svg was added to our web/public/_assets directory. We have created a dedicated directory named connector-xero which contains necessary files like def.ts, index.ts, package.json, and server.ts.

  • Data Structures and Server Integration in New Directory:
    In the new connector-xero directory, we've defined necessary data structures like xeroSchemas, helpers, and xeroDef in the def.ts file. Also, xeroServer is added to the server.ts file for better organization and server-side operation.

  • Addition of Dependencies:
    New dependencies namely, @opensdks/sdk-xero, @opensdks/util-zod, @usevenice/cdk, and @usevenice/util are added to the connector-xero/package.json file which ensures successful functioning of the added module.

Keep in mind these improvements aim to enhance integration capabilities of our project with Xero, making our data communication robust and more streamlined.

Copy link
Contributor

@tonyxiao tonyxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge now (annotating wip) or later once you add sync

@jatinsandilya jatinsandilya changed the title feat: add xero connector to venice feat(wip): add xero connector to venice Mar 31, 2024
@jatinsandilya jatinsandilya merged commit fad365b into main Mar 31, 2024
6 checks passed
@jatinsandilya jatinsandilya deleted the feat/add-xero-connector branch March 31, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants