Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ink_lang_macro UI tests into macro-specific folders #934

Merged
merged 3 commits into from
Sep 21, 2021

Conversation

Robbepop
Copy link
Collaborator

Carved out refactoring work from #665 to shrink its diff.

This is because our CI currently fails if we have multiple test cases.
@codecov-commenter
Copy link

Codecov Report

Merging #934 (bc145f1) into master (41b0a1c) will increase coverage by 1.97%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #934      +/-   ##
==========================================
+ Coverage   84.20%   86.18%   +1.97%     
==========================================
  Files         173      171       -2     
  Lines        7939     7656     -283     
==========================================
- Hits         6685     6598      -87     
+ Misses       1254     1058     -196     
Impacted Files Coverage Δ
...g/macro/tests/ui/contract/pass/01-noop-contract.rs 16.66% <ø> (ø)
...acro/tests/ui/contract/pass/02-flipper-contract.rs 8.33% <ø> (ø)
.../tests/ui/contract/pass/03-incrementer-contract.rs 5.00% <ø> (ø)
.../macro/tests/ui/contract/pass/04-erc20-contract.rs 1.47% <ø> (ø)
...macro/tests/ui/contract/pass/05-erc721-contract.rs 0.58% <ø> (ø)
...g/macro/tests/ui/contract/pass/06-non-ink-items.rs 16.66% <ø> (ø)
...tests/ui/contract/pass/07-flipper-as-dependency.rs 100.00% <ø> (ø)
...ui/contract/pass/08-flipper-as-dependency-trait.rs 100.00% <ø> (ø)
...lang/macro/tests/ui/contract/pass/09-static-env.rs 12.50% <ø> (ø)
...ro/tests/ui/contract/pass/10-derive-for-storage.rs 16.66% <ø> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41b0a1c...bc145f1. Read the comment docs.

@Robbepop Robbepop merged commit 87867ef into master Sep 21, 2021
@Robbepop Robbepop deleted the robin-move-ui-tests branch September 21, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants