Implement MVP for new off-chain testing engine #712

cmichi · 2021-03-02T13:06:10Z

MVP for #565.

ToDo

crates/engine/LICENSE

crates/engine/src/typed_encoded.rs

.gitlab-ci.yml

crates/engine/src/exec_context.rs

crates/engine/src/ext.rs

crates/env/src/engine/off_chain/mod.rs

crates/env/src/engine/on_chain/mod.rs

crates/env/src/error.rs

crates/env_types/Cargo.toml

crates/storage/src/alloc/init.rs

Robbepop

All in all looks good but there is a fundamental problem with ink_engine trying to expose its API as a singleton through free standing methods that require their engine but instead if should expose its API as a single type (the engine) with methods on the engine so that the ink_env can do what it always did and properly turn it into a thread_local and dispatch between engines.

crates/engine/src/types.rs

crates/env/src/engine/experimental_off_chain/types.rs

crates/env/src/engine/mod.rs

crates/storage/src/collections/binary_heap/tests.rs

crates/storage/src/collections/hashmap/tests.rs

examples/erc20/lib.rs

crates/engine/src/ext.rs

crates/engine/src/exec_context.rs

crates/engine/src/ext.rs

crates/engine/src/storage.rs

crates/engine/src/test_api.rs

crates/env/src/engine/experimental_off_chain/impls.rs

Robbepop · 2021-04-21T09:56:11Z

crates/env/src/engine/experimental_off_chain/impls.rs

+    fn hash(input: &[u8], output: &mut <Self as HashOutput>::Type) {
+        type OutputType = [u8; 16];
+        static_assertions::assert_type_eq_all!(
+            <Blake2x128 as HashOutput>::Type,


Suggested change

<Blake2x128 as HashOutput>::Type,

<Self as HashOutput>::Type,

Unfortunately results in this error:

error[E0401]: can't use generic parameters from outer function --> crates/env/src/engine/experimental_off_chain/impls.rs:56:14 | 52 | impl CryptoHash for Blake2x128 { | ---- `Self` type implicitly declared here, by this `impl` ... 56 | <Self as HashOutput>::Type, | ^^^^ | | | use of generic parameter from outer function | use a type here instead

crates/env/src/engine/experimental_off_chain/impls.rs

crates/env/src/engine/experimental_off_chain/test_api.rs

codecov-commenter · 2021-04-29T04:27:46Z

Codecov Report

Merging #712 (813301e) into master (5571724) will decrease coverage by 14.96%.
The diff coverage is 80.33%.

❗ Current head 813301e differs from pull request most recent head 8fec9ae. Consider uploading reports for the commit 8fec9ae to get more accurate results

@@             Coverage Diff             @@
##           master     #712       +/-   ##
===========================================
- Coverage   83.33%   68.36%   -14.97%     
===========================================
  Files         163      174       +11     
  Lines        7502     7888      +386     
===========================================
- Hits         6252     5393      -859     
- Misses       1250     2495     +1245

Impacted Files	Coverage Δ
crates/env/src/backend.rs	`0.00% <ø> (ø)`
crates/storage/src/collections/hashmap/tests.rs	`100.00% <ø> (ø)`
crates/storage/src/collections/smallvec/tests.rs	`100.00% <ø> (ø)`
crates/storage/src/collections/stash/tests.rs	`100.00% <ø> (ø)`
crates/storage/src/collections/vec/tests.rs	`100.00% <ø> (ø)`
crates/storage/src/lazy/lazy_cell.rs	`97.40% <ø> (ø)`
...tes/env/src/engine/experimental_off_chain/types.rs	`21.05% <21.05%> (ø)`
crates/engine/src/ext.rs	`65.85% <65.85%> (ø)`
crates/engine/src/types.rs	`66.66% <66.66%> (ø)`
...tes/env/src/engine/experimental_off_chain/impls.rs	`80.82% <80.82%> (ø)`
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19200dd...8fec9ae. Read the comment docs.

crates/engine/src/exec_context.rs

crates/engine/src/ext.rs

crates/engine/src/test_api.rs

crates/env/src/engine/experimental_off_chain/impls.rs

crates/env/src/engine/experimental_off_chain/test_api.rs

Robbepop

Let's ship it!

cmichi added 5 commits March 2, 2021 14:02

Add engine crate

a693a0b

Add env_types crate

e3ea5e4

Adapt env, lang and storage

eff3ada

Adapt examples

da08ba7

Adapt CI

def45c2

cmichi force-pushed the cmichi-implement-new-offchain-engine-mvp branch from df8e55c to def45c2 Compare March 2, 2021 13:16

Robbepop reviewed Mar 2, 2021

View reviewed changes

crates/engine/LICENSE Outdated Show resolved Hide resolved

crates/engine/src/typed_encoded.rs Outdated Show resolved Hide resolved

Symlink license and readme

3956a2c

cmichi marked this pull request as draft March 3, 2021 09:26

cmichi added 4 commits March 3, 2021 11:17

Throw TypedEncoded out of engine

a0012e9

Improve Erc20

606c69b

Merge branch 'master' into cmichi-implement-new-offchain-engine-mvp

6850b4b

Bump versions to rc3

9c5f2ba

Robbepop requested changes Mar 3, 2021

View reviewed changes

Michael Müller and others added 4 commits March 15, 2021 16:48

Fix clippy error: Manual implementation of Option::map (#717)

cc8143d

Implement comments

edab873

Merge branch 'master' into cmichi-implement-new-offchain-engine-mvp

340185d

Fix yml

cb54a77

cmichi force-pushed the cmichi-implement-new-offchain-engine-mvp branch 12 times, most recently from eeb68c3 to bc131ca Compare March 17, 2021 05:49

Fix function signature

46adef3

Robbepop reviewed Mar 26, 2021

View reviewed changes

cmichi added 9 commits April 13, 2021 12:53

Get rid of engines singleton

1caada4

Revert instantiate stuff

8a2831a

Implement review comments

c8117a9

Make Storage non-generic

da71eea

Merge branch 'master' into cmichi-implement-new-offchain-engine-mvp

b8ba878

Improve API for emmitted events

b81e4c2

Migrate to panic_any

bff4609

Merge branch 'master' into cmichi-implement-new-offchain-engine-mvp

655b425

Clean up import

63da646

Robbepop reviewed Apr 15, 2021

View reviewed changes

crates/engine/src/ext.rs Outdated Show resolved Hide resolved

Import panic_any

813301e

Robbepop reviewed Apr 21, 2021

View reviewed changes

cmichi added 5 commits April 28, 2021 10:26

Merge branch 'master' into cmichi-implement-new-offchain-engine-mvp

c651d53

Implement comments

8391f8c

Fix param

863628d

Use type

b5c3688

Store balances in chain storage

eafe7ac

cmichi added 2 commits April 29, 2021 07:21

Fix tests

8f64f38

Use individual storage per contract

68734c8

Robbepop reviewed May 3, 2021

View reviewed changes

cmichi added 2 commits May 10, 2021 06:55

Implement comments

35dd9e6

Merge branch 'master' into cmichi-implement-new-offchain-engine-mvp

8fec9ae

cmichi mentioned this pull request May 10, 2021

New off-chain engine: Implement utility methods #787

Closed

6 tasks

Robbepop approved these changes May 10, 2021

View reviewed changes

cmichi merged commit 1a19f93 into master May 10, 2021

cmichi deleted the cmichi-implement-new-offchain-engine-mvp branch May 10, 2021 11:32

cmichi mentioned this pull request Sep 27, 2022

Member Request polkadot-fellows/seeding#19

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement MVP for new off-chain testing engine #712

Implement MVP for new off-chain testing engine #712

cmichi commented Mar 2, 2021 •

edited

Loading

Robbepop left a comment

Robbepop Apr 21, 2021

cmichi Apr 28, 2021

codecov-commenter commented Apr 29, 2021 •

edited

Loading

Robbepop left a comment

	<Blake2x128 as HashOutput>::Type,
	<Self as HashOutput>::Type,

Implement MVP for new off-chain testing engine #712

Implement MVP for new off-chain testing engine #712

Conversation

cmichi commented Mar 2, 2021 • edited Loading

ToDo

Robbepop left a comment

Choose a reason for hiding this comment

Robbepop Apr 21, 2021

Choose a reason for hiding this comment

cmichi Apr 28, 2021

Choose a reason for hiding this comment

codecov-commenter commented Apr 29, 2021 • edited Loading

Codecov Report

Robbepop left a comment

Choose a reason for hiding this comment

cmichi commented Mar 2, 2021 •

edited

Loading

codecov-commenter commented Apr 29, 2021 •

edited

Loading