Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure topics are unique #594

Merged
merged 21 commits into from
Dec 2, 2020
Merged

Ensure topics are unique #594

merged 21 commits into from
Dec 2, 2020

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Nov 25, 2020

Closes #589.

@cmichi cmichi requested a review from Robbepop November 25, 2020 11:59
crates/lang/src/events.rs Outdated Show resolved Hide resolved
crates/lang/src/events.rs Outdated Show resolved Hide resolved
crates/lang/src/events.rs Outdated Show resolved Hide resolved
crates/lang/src/lib.rs Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Nov 26, 2020

Codecov Report

Merging #594 (1a23197) into master (2100fa7) will increase coverage by 12.80%.
The diff coverage is 78.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #594       +/-   ##
===========================================
+ Coverage   67.26%   80.07%   +12.80%     
===========================================
  Files         155      156        +1     
  Lines        6925     6945       +20     
===========================================
+ Hits         4658     5561      +903     
+ Misses       2267     1384      -883     
Impacted Files Coverage Δ
crates/lang/macro/tests/unique_topics.rs 66.66% <66.66%> (ø)
crates/env/src/engine/off_chain/db/events.rs 87.87% <100.00%> (+78.20%) ⬆️
crates/env/src/topics.rs 100.00% <100.00%> (+100.00%) ⬆️
crates/lang/codegen/src/generator/events.rs 100.00% <100.00%> (+100.00%) ⬆️
crates/storage/src/lazy/lazy_cell.rs 98.50% <0.00%> (+1.10%) ⬆️
crates/env/src/engine/off_chain/impls.rs 57.97% <0.00%> (+2.89%) ⬆️
crates/env/src/engine/off_chain/typed_encoded.rs 80.48% <0.00%> (+4.81%) ⬆️
...ates/storage/src/collections/hashmap/fuzz_tests.rs 100.00% <0.00%> (+5.47%) ⬆️
crates/env/src/api.rs 43.75% <0.00%> (+6.25%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2100fa7...3c6334f. Read the comment docs.

crates/env/src/topics.rs Show resolved Hide resolved
crates/lang/codegen/src/generator/events.rs Outdated Show resolved Hide resolved
crates/lang/codegen/src/generator/events.rs Outdated Show resolved Hide resolved
crates/lang/macro/tests/unique_topics.rs Show resolved Hide resolved
Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all looks good to me!
Just some minor fixes.

crates/env/src/topics.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmichi cmichi merged commit 64eec2c into master Dec 2, 2020
@cmichi cmichi deleted the cmichi-err-on-duplicate-topic branch December 2, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When set '0' value in contracts event, may cause Error::ContractTrapped and panic in contract
3 participants