-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ink_e2e]
improve call API, remove build_message
+ callback
#1782
Conversation
This reverts commit e733996.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
We should reflect the change in a CHANGELOG.md
. Since we so far always released in lockstep with the rest of ink!, I would just add it there for now.
Codecov Report
@@ Coverage Diff @@
## master #1782 +/- ##
==========================================
- Coverage 52.09% 52.05% -0.05%
==========================================
Files 207 207
Lines 6653 6653
==========================================
- Hits 3466 3463 -3
- Misses 3187 3190 +3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Resurrecting the idea from #1669.
I believe it closes #1644, since the main thing is removing that ugly callback. This may not be the fina or most sophisticatedl API, but an increment in the right direction for better quality of life for
e2e
test devs.Replaces
build_message
and callback with a simpler: