Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Bring back ink-waterfall tests #1667

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Feb 21, 2023

Time to see if the issues have been fixed in polkadot-js in the meantime.

@paritytech-cicd-pr
Copy link

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

⚠️ The ink! master is ahead of your branch, this might skew the comparison data below.

These are the results when building the examples/* contracts from this branch with cargo-contract 2.0.0-rc-da24337 and comparing them to ink! master:

Δ Optimized Size Δ Used Gas Total Optimized Size Total Used Gas
accumulator 1.12 K
adder +0.06 K 1.83 K
call-runtime -1.80 K
contract-terminate +129_990 1.29 K 129_990
contract-transfer +0.06 K +129_990 1.51 K 129_990
custom-environment 2.56 K
custom_allocator 8.38 K
delegator +0.12 K +259_980 6.13 K 259_980
dns +0.07 K +389_970 8.96 K 389_970
erc1155 +0.08 K +779_940 17.31 K 779_940
erc20 +0.08 K +389_970 7.67 K 389_970
erc721 +0.09 K +1_039_920 11.50 K 1_039_920
flipper +129_990 1.41 K 129_990
forward-calls +0.06 K +259_980 2.52 K 259_980
incrementer 1.23 K
mapping_integration_tests +0.07 K 3.43 K
mother 10.44 K
multisig +0.08 K +779_940 24.25 K 779_940
payment-channel +0.07 K 6.07 K
psp22-extension 6.62 K
rand-extension 2.94 K
set-code-hash +0.05 K 1.66 K
subber +0.06 K 1.85 K
trait-erc20 +0.07 K +389_970 8.10 K 389_970
trait-flipper +129_990 1.19 K 129_990
trait-incrementer +259_980 1.35 K 259_980
updated-incrementer +0.05 K 1.66 K

Link to the run | Last update: Tue Feb 28 10:07:16 CET 2023

@cmichi cmichi marked this pull request as ready for review February 28, 2023 09:09
@cmichi cmichi requested review from a team, ascjones, HCastano and SkymanOne as code owners February 28, 2023 09:09
@cmichi cmichi merged commit 426963d into master Feb 28, 2023
@cmichi cmichi deleted the cmichi-bring-back-waterfall branch February 28, 2023 09:10
@ascjones
Copy link
Collaborator

Awesome! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants