Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate erc20 waterfall test to e2e #1513

Merged
merged 10 commits into from
Dec 16, 2022
Merged

Migrate erc20 waterfall test to e2e #1513

merged 10 commits into from
Dec 16, 2022

Conversation

ascjones
Copy link
Collaborator

Part of #1510

@ascjones ascjones mentioned this pull request Nov 21, 2022
Open
20 tasks
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022 •
edited
Loading

Codecov Report

Merging #1513 (2ebac56) into master (fc543da) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1513      +/-   ##
==========================================
+ Coverage   46.49%   46.52%   +0.03%     
==========================================
  Files         204      204              
  Lines        6315     6317       +2     
==========================================
+ Hits         2936     2939       +3     
+ Misses       3379     3378       -1
Impacted Files Coverage Δ
crates/e2e/src/lib.rs 25.00% <0.00%> (-8.34%) ⬇️
crates/allocator/src/bump.rs 88.23% <0.00%> (ø)
crates/ink/ir/src/ir/attrs.rs 78.67% <0.00%> (+0.27%) ⬆️
crates/metadata/src/layout/mod.rs 77.50% <0.00%> (+1.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ascjones ascjones marked this pull request as ready for review November 30, 2022 15:10
@HCastano HCastano merged commit 8165c70 into master Dec 16, 2022
@HCastano HCastano deleted the aj/e2e-migrate-erc20 branch December 16, 2022 21:48
HCastano pushed a commit that referenced this pull request Jan 23, 2023
@ascjones @HCastano
Migrate erc20 waterfall test to e2e (#1513)
a58e8bb 
* erc20 transfer e2e test

* Add allowances todo

* Migrate e2e_transfer test

* WIP migrate e2e allowances

* WIP allowance test

* Remove mut

* Complete approval example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HCastano HCastano HCastano approved these changes

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ascjones @codecov-commenter @HCastano