Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Submarine UI / UX #37

Merged
merged 22 commits into from
Nov 13, 2023
Merged

feat: add Submarine UI / UX #37

merged 22 commits into from
Nov 13, 2023

Conversation

DoubleOTheven
Copy link
Contributor

Merge after this PR

Contract View

Screenshot 2023-08-15 at 4 17 40 PM

Wallet Connect View

This will show all wallets that are installed on your machine, or a list of wallets you can install if there are none.

Screenshot 2023-08-15 at 4 18 09 PM

Screen Off

Screenshot 2023-08-15 at 4 19 16 PM

@peetzweg
Copy link
Contributor

New UI also does not showcase errors.
#25 (comment)

Screenshot 2023-08-21 at 10 58 45

@peetzweg
Copy link
Contributor

Audio is a fun addition, got a heart attack though as my speakers where on full blast. Maybe default off?

Will these examples be hosted somewhere? I think it could use an index page to switch between examples maybe?

How about a link to the actual contract code in the repo? It should also showcase the contract itself right? 🤔

@peetzweg
Copy link
Contributor

Does not handle smaller screens that well. Errors are a bit hard to read in this font, imho.

short-smol.mov

@peetzweg peetzweg self-requested a review August 21, 2023 09:10
@peetzweg
Copy link
Contributor

Maybe we could dedupe the README.md, .gitignore, tsconfig.node.json, tsconfig.json etc. files across all the frontend folders?
Also a lot of empty config files. Lot of bloat files for a minimal frontend example to my taste. But just my personal taste after all. 🤷

Guess these examples should be runnable each on their own.

@peetzweg peetzweg merged commit 254fa73 into main Nov 13, 2023
3 checks passed
@peetzweg peetzweg deleted the sr/submarine branch November 13, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants