-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make definitions consistent #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can treat the need for .schema({ more_stuff })
as YAGNI until proven otherwise.
Sounds good! Will merge now and we can always edit/add more later. |
Are there any documentation updates to make based on these changes? |
Yes indeedy! We'll want to rewrite common-definitions.md to explain the new way of using the definitions since they return both |
Description
Turn all
schema
anduiSchema
in definitions into functions to make their usage consistent. Here's an example of what that usage would look like: https://github.com/usds/us-forms-system-starter-app/compare/test-new-schema-additions-to-usfs?expand=1.Connected to #222