Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make definitions consistent #225

Merged
merged 8 commits into from
Aug 16, 2018
Merged

Conversation

annekainicUSDS
Copy link
Contributor

@annekainicUSDS annekainicUSDS commented Aug 15, 2018

Description

Turn all schema and uiSchema in definitions into functions to make their usage consistent. Here's an example of what that usage would look like: https://github.com/usds/us-forms-system-starter-app/compare/test-new-schema-additions-to-usfs?expand=1.

Connected to #222

Copy link
Contributor

@dmethvin-gov dmethvin-gov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can treat the need for .schema({ more_stuff }) as YAGNI until proven otherwise.

@annekainicUSDS
Copy link
Contributor Author

Sounds good! Will merge now and we can always edit/add more later.

@annekainicUSDS annekainicUSDS merged commit 4d1d6dc into master Aug 16, 2018
@annekainicUSDS annekainicUSDS deleted the make-definitions-consistent branch August 16, 2018 02:53
@bernars-usa
Copy link
Contributor

Are there any documentation updates to make based on these changes?

@dmethvin-gov
Copy link
Contributor

Yes indeedy! We'll want to rewrite common-definitions.md to explain the new way of using the definitions since they return both schema and uiSchema. The good news is that they're all consistently functions now and we'll just need to explain what the arguments are but nothing else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants