Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent spacing between 1 line & 2 line checkboxes #233

Closed
rtluu opened this issue Aug 22, 2018 · 2 comments
Closed

Inconsistent spacing between 1 line & 2 line checkboxes #233

rtluu opened this issue Aug 22, 2018 · 2 comments
Assignees
@dmethvin-gov
Labels
[practice] engineering Engineering related work [type] bug Something isn't working as expected
Milestone
End of Phase 1

Comments

@rtluu
Copy link

rtluu commented Aug 22, 2018 •
edited
Loading

Describe the bug
Inconsistent spacing between 1 line & 2 line checkboxes

To Reproduce
This is due to a bug in the us-forms-system (missing >) in
.schemaform-first-field .schemaform-label, .schemaform-first-field > .usa-input-error in us-forms-system

Steps to reproduce the behavior:

  1. Go to 'staging.vets.gov/education/gi-bill-school-feedback/'
  2. Click on 'Submit Your Feedback'
  3. Click on 'I want to submit my feedback anonymously' --> Continue
  4. This is where the error occurred, but we put in an temporary fix until this is resolved in us-forms-system

Screenshots
Screen Shot 2018-08-15 at 1.37.56 PM.png

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
  • Version 68.0.3440.106
@annekainicUSDS annekainicUSDS added the [practice] engineering Engineering related work label Aug 22, 2018
@jcmeloni-usds jcmeloni-usds added the [type] bug Something isn't working as expected label Sep 20, 2018
dmethvin-gov added a commit to dmethvin-gov/us-forms-system that referenced this issue Sep 28, 2018
@dmethvin-gov
Fix spacing of checkboxes with multi-line labels
33c6fc3 
Fixes usds#233
@dmethvin-gov dmethvin-gov mentioned this issue Sep 28, 2018
Closed
9 tasks
@dmethvin-gov dmethvin-gov self-assigned this Sep 28, 2018
@cehsu
Copy link

cehsu commented Oct 16, 2018

The style rule that is being used to fix this temporarily is:

.form-checkbox>input[type=checkbox]+.schemaform-label {
    margin-top: 0;
}

It is specified here.

Here is a comparison to illustrate how this is being fixed on Vets.gov:
screen shot 2018-10-16 at 9 19 59 am
screen shot 2018-10-16 at 9 20 02 am

dmethvin-gov added a commit to dmethvin-gov/us-forms-system that referenced this issue Oct 29, 2018
@dmethvin-gov
Fix spacing of checkboxes with multi-line labels
e18b5f5 
Fixes usds#233
@annekainicUSDS
Copy link
Contributor

PR was closed: #293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmethvin-gov dmethvin-gov

Labels
[practice] engineering Engineering related work [type] bug Something isn't working as expected
Projects
None yet
Milestone
End of Phase 1
Development

Successfully merging a pull request may close this issue.

Fix spacing of checkboxes with multi-line labels dmethvin-gov/us-forms-system
5 participants
@rtluu @cehsu @jcmeloni-usds @annekainicUSDS @dmethvin-gov