[WIP] Upgrade to react router 4 #27
Conversation
| const pageList = createPageList(formConfig, formPages); | ||
|
|
||
| export default function Form({ location }) { | ||
| const introRoute = { |
There was a problem hiding this comment.
Right now these props passed to each route are hard-coded, but this will go away once we're able to figure out how to generate the routes automatically.
| <FormApp formConfig={formConfig} currentLocation={location}> | ||
|
|
||
| <Switch> | ||
| <Route exact path="/introduction" render={props => ( |
There was a problem hiding this comment.
This is the only way I've gotten the pages to render properly so far. I've commented out the programmatic way of generating routes at the bottom of this file so we can play around with it, but so far this doesn't seem to be working.
| @@ -9,7 +9,7 @@ const formConfig = { | |||
| transformForSubmit: '', | |||
| submitUrl: '', | |||
| introduction: Introduction, | |||
| confirmation: '', | |||
| confirmation: Introduction, | |||
There was a problem hiding this comment.
Temporarily adding this so that the route generation doesn't break because '' isn't a valid React component. Will need to go back and remove/fix this later.
|
|
||
| const routes = createRoutes(formConfig); | ||
| function createRouteConfig(form) { |
There was a problem hiding this comment.
This function is a replacement of the createRoutes function from us-forms-system. The main difference right now is that it only generates the config for the main form page routes, not including intro, review-and-submit, and confirmation pages. We'll want to add those back in once we can get the route generation working properly.
| "mocha": "^5.2.0", | ||
| "react-redux": "^5.1.1", |
There was a problem hiding this comment.
Added some packages needed only because I'm testing these changes against my local copy of us-forms-system right now. Can delete this once I revert to using the remote version of us-forms-system.
|
Closing this out but if someone wants to work on a refactor I'll be glad to talk. Ultimately I think the forms library itself shouldn't be wired to a particular router and instead would provide an API so that the app (this repo) would control things. |
WIP version of ugprading to react-router v4. So far I've gotten things to mostly work by hard-coding the routes, but to programmatically generate them from a config is not working. Various things I've tried so far don't seem to illuminate why that is. Looking for a second pair of eyes on this!