ref-US4R-40: Removed TBB dependency, added FPGATemperature getter, fi…

…xed jenkins file. (#236)
us4useu · Oct 9, 2021 · 012f141 · 012f141
1 parent 52bb50e
commit 012f141
Show file tree

Hide file tree

Showing 11 changed files with 41 additions and 42 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -101,8 +101,7 @@ find_package(Eigen3 REQUIRED)
 if("${ARRUS_BUILD_PLATFORM}" STREQUAL "windows")
     set(ARRUS_OS_DEPS "")
 else("${ARRUS_BUILD_PLATFORM}" STREQUAL "linux")
-    find_package(TBB REQUIRED)
-    set(ARRUS_OS_DEPS tbb)
+    set(ARRUS_OS_DEPS "")
 endif()
 ################################################################################
 # Sub-projects

diff --git a/Jenkinsfile b/Jenkinsfile
@@ -135,12 +135,11 @@ def getBranchName() {
 }
 
 def isDevelopOnOff() {
-    return "ON";
-    // return env.BRANCH_NAME == "develop" ? "ON" : "OFF";
+    return env.BRANCH_NAME == "develop" ? "ON" : "OFF";
 }
 
 def getBuildName(build) {
     wrap([$class: 'BuildUser']) {
         return "#${build.id} (${env.BUILD_USER_ID})";
     }
-}
+}
diff --git a/arrus/core/api/devices/us4r/Us4OEM.h b/arrus/core/api/devices/us4r/Us4OEM.h
@@ -17,6 +17,8 @@ class Us4OEM : public Device, public TriggerGenerator {
 
     virtual double getSamplingFrequency() = 0;
 
+    virtual float getFPGATemperature() = 0;
+
     Us4OEM(Us4OEM const&) = delete;
     Us4OEM(Us4OEM const&&) = delete;
     void operator=(Us4OEM const&) = delete;

diff --git a/arrus/core/api/devices/us4r/Us4R.h b/arrus/core/api/devices/us4r/Us4R.h
@@ -138,6 +138,8 @@ class Us4R : public DeviceWithComponents {
     virtual void start() = 0;
     virtual void stop() = 0;
 
+    virtual uint8_t getNumberOfUs4OEMs() = 0;
+
     Us4R(Us4R const&) = delete;
     Us4R(Us4R const&&) = delete;
     void operator=(Us4R const&) = delete;

diff --git a/arrus/core/devices/us4r/Us4RImpl.cpp b/arrus/core/devices/us4r/Us4RImpl.cpp
@@ -270,4 +270,8 @@ void Us4RImpl::setActiveTermination(std::optional<uint16> value) {
     setRxSettings(newRxSettings);
 }
 
+uint8_t Us4RImpl::getNumberOfUs4OEMs() {
+    return us4oems.size();
+}
+
 }
diff --git a/arrus/core/devices/us4r/Us4RImpl.h b/arrus/core/devices/us4r/Us4RImpl.h
@@ -120,6 +120,7 @@ class Us4RImpl : public Us4R {
     void setLpfCutoff(uint32 value) override;
     void setDtgcAttenuation(std::optional<uint16> value) override;
     void setActiveTermination(std::optional<uint16> value) override;
+    uint8_t getNumberOfUs4OEMs() override;
 
 private:
     UltrasoundDevice *getDefaultComponent();

diff --git a/arrus/core/devices/us4r/external/ius4oem/IUs4OEMInitializerImpl.h b/arrus/core/devices/us4r/external/ius4oem/IUs4OEMInitializerImpl.h
@@ -2,9 +2,9 @@
 #define ARRUS_CORE_DEVICES_US4R_EXTERNAL_IUS4OEM_IUS4OEMINITIALIZERIMPL_H
 
 #include <algorithm>
-#include <execution>
 #include <mutex>
 #include <iostream>
+#include <future>
 
 #include "IUs4OEMInitializer.h"
 
@@ -32,30 +32,17 @@ class IUs4OEMInitializerImpl : public IUs4OEMInitializer {
         // Us4OEMs are initialized here.
     }
 private:
+
     void initializeUs4oems(std::vector<IUs4OEMHandle> &ius4oems, int level) {
-        std::vector<std::exception> exceptions;
-        std::mutex exceptions_mutex;
+        std::vector<std::future<void>> results;
 
-        std::for_each(
-            std::execution::par_unseq, std::begin(ius4oems), std::end(ius4oems),
-            [&](IUs4OEMHandle &u) {
-                try {
-                    u->Initialize(level);
-                }
-                catch(const std::exception &e) {
-                    std::lock_guard guard(exceptions_mutex);
-                    exceptions.push_back(e);
-                }
-                catch(...) {
-                    std::lock_guard guard(exceptions_mutex);
-                    exceptions.push_back(std::runtime_error("Unknown exception during Us4OEM initialization."));
-                }
-            }
-        );
-        if(!exceptions.empty()) {
-            // TODO create a complete list of error messages
-            // now throw any of the exception
-            throw exceptions.front();
+        for(IUs4OEMHandle &ius4oem : ius4oems) {
+            std::future<void> result = std::async(std::launch::async, [&ius4oem, level]() {ius4oem->Initialize(level);});
+            results.push_back(std::move(result));
+        }
+        for(auto &result: results) {
+            result.wait();
+            result.get(); // wait and throw exception if necessary.
         }
     }
 };

diff --git a/arrus/core/devices/us4r/external/ius4oem/IUs4OEMInitializerImplTest.cpp b/arrus/core/devices/us4r/external/ius4oem/IUs4OEMInitializerImplTest.cpp
@@ -10,6 +10,7 @@ namespace {
 using namespace arrus::devices;
 using ::testing::Return;
 using ::testing::InSequence;
+using ::testing::Sequence;
 
 // Test if the input array is approprietaly sorted
 TEST(IUs4OEMInitializerImplTest, Us4OEMsSortedApproprietaly) {
@@ -45,24 +46,24 @@ TEST(IUs4OEMInitializerImplTest, Us4OEMsInitializedProperly) {
     ON_CALL(GET_MOCK_PTR(ius4oems[1]), GetID)
             .WillByDefault(Return(0));
 
-    // The actual order: 1, 0
     {
-        InSequence seq;
+        Sequence us4oem0Seq;
+        Sequence us4oem1Seq;
 
-        EXPECT_CALL(GET_MOCK_PTR(ius4oems[1]), Initialize(1));
-        EXPECT_CALL(GET_MOCK_PTR(ius4oems[0]), Initialize(1));
+        EXPECT_CALL(GET_MOCK_PTR(ius4oems[1]), Initialize(1)).InSequence(us4oem1Seq);
+        EXPECT_CALL(GET_MOCK_PTR(ius4oems[0]), Initialize(1)).InSequence(us4oem0Seq);
 
-        EXPECT_CALL(GET_MOCK_PTR(ius4oems[1]), Synchronize());
-        EXPECT_CALL(GET_MOCK_PTR(ius4oems[1]), Initialize(2));
-        EXPECT_CALL(GET_MOCK_PTR(ius4oems[0]), Initialize(2));
+        EXPECT_CALL(GET_MOCK_PTR(ius4oems[1]), Synchronize()).InSequence(us4oem1Seq, us4oem0Seq);
+        EXPECT_CALL(GET_MOCK_PTR(ius4oems[1]), Initialize(2)).InSequence(us4oem1Seq);
+        EXPECT_CALL(GET_MOCK_PTR(ius4oems[0]), Initialize(2)).InSequence(us4oem0Seq);
 
-        EXPECT_CALL(GET_MOCK_PTR(ius4oems[1]), Synchronize());
-        EXPECT_CALL(GET_MOCK_PTR(ius4oems[1]), Initialize(3));
-        EXPECT_CALL(GET_MOCK_PTR(ius4oems[0]), Initialize(3));
+        EXPECT_CALL(GET_MOCK_PTR(ius4oems[1]), Synchronize()).InSequence(us4oem1Seq, us4oem0Seq);
+        EXPECT_CALL(GET_MOCK_PTR(ius4oems[1]), Initialize(3)).InSequence(us4oem1Seq);
+        EXPECT_CALL(GET_MOCK_PTR(ius4oems[0]), Initialize(3)).InSequence(us4oem0Seq);
 
-        EXPECT_CALL(GET_MOCK_PTR(ius4oems[1]), Synchronize());
-        EXPECT_CALL(GET_MOCK_PTR(ius4oems[1]), Initialize(4));
-        EXPECT_CALL(GET_MOCK_PTR(ius4oems[0]), Initialize(4));
+        EXPECT_CALL(GET_MOCK_PTR(ius4oems[1]), Synchronize()).InSequence(us4oem1Seq, us4oem0Seq);
+        EXPECT_CALL(GET_MOCK_PTR(ius4oems[1]), Initialize(4)).InSequence(us4oem1Seq);
+        EXPECT_CALL(GET_MOCK_PTR(ius4oems[0]), Initialize(4)).InSequence(us4oem0Seq);
     }
 
     IUs4OEMInitializerImpl initializer;

diff --git a/arrus/core/devices/us4r/probeadapter/ProbeAdapterImplTest.cpp b/arrus/core/devices/us4r/probeadapter/ProbeAdapterImplTest.cpp
@@ -104,6 +104,7 @@ class MockUs4OEM : public Us4OEMImplBase {
     MOCK_METHOD(Ius4OEMRawHandle, getIUs4oem, (), (override));
     MOCK_METHOD(void, enableSequencer, (), (override));
     MOCK_METHOD(std::vector<uint8_t>, getChannelMapping, (), (override));
+    MOCK_METHOD(float, getFPGATemperature, (), (override));
 };
 
 class AbstractProbeAdapterImplTest : public ::testing::Test {

diff --git a/arrus/core/devices/us4r/us4oem/Us4OEMImpl.cpp b/arrus/core/devices/us4r/us4oem/Us4OEMImpl.cpp
@@ -639,6 +639,8 @@ inline void Us4OEMImpl::setActiveTerminationAfe(std::optional<uint16> param, boo
     }
 }
 
-
+float Us4OEMImpl::getFPGATemperature() {
+    return ius4oem->GetFPGATemp();
+}
 
 }
diff --git a/arrus/core/devices/us4r/us4oem/Us4OEMImpl.h b/arrus/core/devices/us4r/us4oem/Us4OEMImpl.h
@@ -117,6 +117,7 @@ class Us4OEMImpl : public Us4OEMImplBase {
 
     std::vector<uint8_t> getChannelMapping() override;
     void setRxSettings(const RxSettings &newSettings) override;
+    float getFPGATemperature() override;
 
 private:
     using Us4OEMBitMask = std::bitset<Us4OEMImpl::N_ADDR_CHANNELS>;
-Original file line number
+Diff line change
@@ Expand Up @@
         }
     }
+    float Us4OEMImpl::getFPGATemperature() {
+        return ius4oem->GetFPGATemp();
+    }
     }