Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calendar): add amCalendar pipe #6

Merged
merged 1 commit into from
Jan 12, 2016
Merged

Conversation

andreialecu
Copy link
Contributor

This refactors things a bit to make room for new pipes.

Also, the implementation of the amCalendar pipe is not marked as pure so that the text can update after midnight.

I am using this on a huge table, so starting hundreds/thousands of timers was leading to performance issues, hence the singleton timer implementation.

urish added a commit that referenced this pull request Jan 12, 2016
feat(calendar): add amCalendar pipe
@urish urish merged commit f95680d into urish:master Jan 12, 2016
@urish
Copy link
Owner

urish commented Jan 12, 2016

Wonderful, thanks!

@urish urish mentioned this pull request Jan 12, 2016
@urish
Copy link
Owner

urish commented Jan 12, 2016

@andreialecu any chance you can also update README with a usage example for amCalendar and send a PR ?

thx!

@andreialecu andreialecu deleted the patch-1 branch January 12, 2016 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants