Improve documentation for locale import. #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I used the amLocale pipe, I was struggeling with getting the locale loaded. When I did something like
```
{{ myMoment | amLocale:'de' | amDateFormat:'MMMM' }}
```
to thow the month of a date, I always got the english name of the month. After searching the issues, I found this comment urish#149 (comment), what finally helped me. I checked my node_modules that moment was installed and just did the import. I didn't test in my project, if the manual installation of moment.js is necesssary on a clean project.
I think, it would improve the documentation, if this note is added.
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I used the amLocale pipe, I was struggeling with getting the locale loaded. When I did something like
to show the month of a date, I always got the english name of the month. After searching the issues, I found #149 (comment), what finally helped me. I checked my node_modules that moment was installed and just did the import. I didn't test in my project, if the manual installation of moment.js is necesssary on a clean project.
I think, it would improve the documentation, if this note is added.