feat(FromUnixPipe):Add unix pipe to parse unix timestamp to moment #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const unixPipe = new FromUnixPipe(), | ||
| datePipe = new DateFormatPipe(); | ||
| const result = datePipe.transform(unixPipe.transform(1456263980), ['hh:mmA']); | ||
| expect(result).toBe('01:46PM'); |
There was a problem hiding this comment.
Thanks! This test is not required, as it is beyond the scope of just testing unixPipe. Also, it will fail in different timezones
urish
added a commit
that referenced
this pull request
Feb 24, 2016
feat(FromUnixPipe):Add unix pipe to parse unix timestamp to moment
|
Thanks! |
|
Released as 0.4.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add from unix pipe to support parse unix timestamp: number or string
#15