“Expression has changed after it was checked” #84 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urish
reviewed
Nov 8, 2016
| this.lastText = momentConstructor(value).from(momentConstructor(), omitSuffix); | ||
|
|
||
| } else { | ||
| this.createTimer(); |
There was a problem hiding this comment.
What is the purpose of calling createTimer() here? If we had a previous value, we have already created the timer, no?
There was a problem hiding this comment.
Its purpose is to recreate the timer once its callback has ran.
When the callback is running, lastText is computed and markForCheck is called. The timer must be recreated. Instead of resubmitting the timer inside the callback timer which could lead to more than one markForCheck for a given transform, I recreate the timer in the transform method because a markForCheck will lead to a transform calls.
Hope I'm understandable.
|
Looks good! I left one comment with a question that I had. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please leave my your comments