-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Бабич Людмила #28
base: master
Are you sure you want to change the base?
Бабич Людмила #28
Conversation
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍏 Пройден линтинг и базовые тесты |
</head> | ||
<body> | ||
<input type="checkbox" class="output-switch"> | ||
<p>Включить отображение списком</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗️ Больше похоже на label
, чем на p
</head> | ||
<body> | ||
<input type="checkbox" class="output-switch"> | ||
<p>Включить отображение списком</p> | ||
<div class="cat"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗️ article
<img src="images/cat_01.jpg" alt="Мурзик"> | ||
</div> | ||
<div class="cat-details"> | ||
<nav class="name-effect"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗️ Тег навигации обычно используется в навигации или меню)
</div> | ||
<div class="cat-details"> | ||
<nav class="name-effect"> | ||
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗️ Зачем ссылки оборачивать в p
?
<input id="star1-0.5" type="radio" title="poor"> | ||
<label class="left-star" for="star1-0.5"></label> | ||
</div> | ||
<div class="price"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗️ Внутри каждого товара можно информацию ещё на секции побить)
{ | ||
padding-right: 20%; | ||
display: inline-block; | ||
*zoom: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Кажется, невалидное правило
-webkit-box-shadow: 4px 4px 4px rgba(0,0,0,.2); | ||
-moz-box-shadow: 4px 4px 4px rgba(0,0,0,.2); | ||
box-shadow: 4px 4px 4px rgba(0,0,0,.2); | ||
-webkit-transition: all .5s ease-out; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗️ Почему на вебките другая функция перемещения?
box-shadow: 4px 4px 4px rgba(0,0,0,.2); | ||
-webkit-transition: all .5s ease-out; | ||
-moz-transition: all .5s ease; | ||
-o-transition: all .5s ease; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗️ Обязательно указывать соответствующие правила без вендорных префиксов, даже если им никто не пользуется
text-align: left; | ||
overflow: hidden; | ||
text-overflow: ellipsis; | ||
color: dimgrey; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗️ Лучше указывать цвета в hex
{ | ||
background-position: 0 0; | ||
height: 37px; | ||
width: 19px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 за спрайты
❗️ Более низкая оценка не ставится, если уже была поставлена более высокая |
🚀 |
Жду правок от Вовы |
Посмотреть решение