Fix: test: side-effect in assertion

Coverity detected: CID 1021642 (#1 of 2): Side effect in assertion (ASSERT_SIDE_EFFECT)assert_side_effect: Argument test_array of assert() has a side effect because the variable is volatile. The containing function might work differently in a non-debug build. Signed-off-by: Mathieu Desnoyers <[email protected]>
urcu · Sep 21, 2015 · 19d0e7e · 19d0e7e
1 parent 999991c
commit 19d0e7e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/tests/benchmark/test_mutex.c b/tests/benchmark/test_mutex.c
@@ -179,8 +179,11 @@ void *thr_reader(void *data)
 	}
 
 	for (;;) {
+		int v;
+
 		pthread_mutex_lock(&lock);
-		assert(test_array.a == 8);
+		v = test_array.a;
+		assert(v == 8);
 		if (caa_unlikely(rduration))
 			loop_sleep(rduration);
 		pthread_mutex_unlock(&lock);

diff --git a/tests/benchmark/test_perthreadlock.c b/tests/benchmark/test_perthreadlock.c
@@ -183,8 +183,11 @@ void *thr_reader(void *data)
 	}
 
 	for (;;) {
+		int v;
+
 		pthread_mutex_lock(&per_thread_lock[tidx].lock);
-		assert(test_array.a == 8);
+		v = test_array.a;
+		assert(v == 8);
 		if (caa_unlikely(rduration))
 			loop_sleep(rduration);
 		pthread_mutex_unlock(&per_thread_lock[tidx].lock);