Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate factory reset flow #1114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

separate factory reset flow #1114

wants to merge 1 commit into from

Conversation

dillon
Copy link
Contributor

@dillon dillon commented Jul 15, 2023

Separates flow for factory reset AKA breach.

closes #1046

Screenshot 2023-07-14 at 7 36 58 PM Screenshot 2023-07-14 at 7 37 07 PM Screenshot 2023-07-14 at 7 37 02 PM

@dillon dillon requested a review from tomholford July 15, 2023 00:45
@jalehman jalehman requested review from shawntobin and pkova and removed request for tomholford September 8, 2023 15:28
shawntobin
shawntobin reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@shawntobin shawntobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested locally with no issues. A couple minor notes:

  • Typo in the filename "usetSetNetworkKeys.ts"
  • We changed the waitMessage text since this PR, so that should probably be updated in this new FactoryReset component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawntobin shawntobin shawntobin left review comments

@pkova pkova Awaiting requested review from pkova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ux: Factory Reset should be an atomic flow
2 participants
@dillon @shawntobin