adding TouchableOpacity to MapMarker.e2e to allow detox .tap() over m… #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick solution to tap on a specific MapMarker based on their testID with Detox, still work in progress
What issue is this PR fixing?
https://github.com/urbi-mobility/urbi-react-native/pull/242 allow to tap MapMarker with Detox
Related react-native-maps#2253 react-native-maps#2252 and react-native-maps#2253 (comment)
How did you test this PR?
Work in progress, the below GIF show how the TouchableOpacity trigger the Marker selection, adding testID to the touchable opacity will allow Detox to trigger
tap()the marker, additionally we need to disableMapViewonPress event inMapView.e2e.