-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds ability to specify bind address #303
adds ability to specify bind address #303
Conversation
@audibleblink first of all, thanks 🙇 for this pull request. It's a good idea 💡 Before I'm ready to merge it, I want to discuss some options with you and @bcoles. Do we want to let the user select the bind address, the hostname, the interface, or all three?@audibleblink 's pull request lets someone select the IP address. I'm in favour of interface or bind address, assuming the former will be more popular. Some examples from other popular tools are:
The local portThe $local_port gets set to 61000. Why did you set this and did it cause problems if left as nil? when '-b', '--bind'
$local_host = arg
$local_port = 61000 Should we allow the user to select the local port?This could be useful for bypassing mis-configured firewalls. nmap ncat Note -- to get interfaces and IP addressesrequire 'socket'
Socket.ip_address_list |
I like this idea.
In regards to command line convention, I'm in favor of If using the adapter name isn't easy/possible, then
I, too, would like to see the hard-coded port removed, if possible. |
@bcoles and @audibleblink I'm working on it on the bind-interface branch. Currently working on the interface validation |
Hi @audibleblink, did this patch work for you, and if so what OS are you using? |
hey all. thanks for looking at this. currently dealing with a 3 day power outage, a newborn, and in-laws. will be a bit before I can add anything here. |
does the firmware in devies prevent this |
Attempt at implementing #302