enforce correct python tags for pure wheels from setup.py #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforce correct python tags for pure Python wheels directly from `setup.py`. This should be more reliable than the current approach. While at it, switch to correct tags for each platforms -- CPython uses "cp" (which unlike "py" is not accepted for PyPy), and PyPy can use pure "pp" without platform specifiers (since no extensions are installed). Fixes uqfoundation#196
|
CC @mmckerns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enforce correct python tags for pure Python wheels directly from
setup.py. This should be more reliable than the current approach. While at it, switch to correct tags for each platforms -- CPython uses "cp" (which unlike "py" is not accepted for PyPy), and PyPy can use pure "pp" without platform specifiers (since no extensions are installed).Fixes #196
Checklist
Documentation and Tests
Release Management