fix issue property highlight #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
=======================================
Coverage 80.58% 80.58%
=======================================
Files 12 12
Lines 309 309
Branches 78 78
=======================================
Hits 249 249
Misses 60 60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
👏 👏 👏 una cosa que ayuda en un PR (sobre todo si el cambio es visual) es agregarle una demo, como ésta
eso refuerza la idea visible de que funciona de 10!!! |
fdodino
approved these changes
Oct 5, 2024
| @@ -8,4 +8,13 @@ object manolo { | |||
| method hacerVolarAPepita() { | |||
| pepita.vola() | |||
| } | |||
| } | |||
|
|
|||
| object pepita_2 { | |||
There was a problem hiding this comment.
Suggested change
| object pepita_2 { | |
| object pepita_2 { |
PalumboN
approved these changes
Oct 8, 2024
Comment on lines
+42
to
+44
| const getDefinitionFromSyntheticMethod = (method: Method) => { | ||
| return method.parent.allFields.find((field) => field.name === method.name && field.isProperty) | ||
| } |
There was a problem hiding this comment.
Esto es algo piola para tener en TS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #50
Se tienen en cuenta las properties a la hora de buscar una definición.