Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coverage #187

Closed
wants to merge 10 commits into from
Closed

Fix coverage #187

wants to merge 10 commits into from

Conversation

ivojawer
Copy link
Contributor

@ivojawer ivojawer commented Oct 1, 2024 •
edited
Loading

  • Agrego un codecov.yml que setupea components (lo que antes eran flags)
  • Correr tests para que tome los subprocesos
    • Usa @vscode/test-cli para correr los tests e2e
    • Usa c8 para para correr los unit tests
  • El coverage se handlea solo en package.json root, asi no hay que tenerlo en cuenta desde los packages

@uqbar-project uqbar-project deleted a comment from codecov bot Oct 3, 2024
@ivojawer ivojawer marked this pull request as ready for review October 3, 2024 03:22
@ivojawer
Copy link
Contributor Author

ivojawer commented Oct 8, 2024

cierro este issue porque el mensaje del coverage se buggeo al cambiar la definicion en el mismo PR.

@ivojawer ivojawer closed this Oct 8, 2024
@fdodino fdodino deleted the fix-coverage branch October 8, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ivojawer