Mejoras autocomplete en Body #165
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
==========================================
- Coverage 83.44% 82.99% -0.46%
==========================================
Files 17 17
Lines 435 441 +6
Branches 97 99 +2
==========================================
+ Hits 363 366 +3
- Misses 72 75 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -82,3 +88,5 @@ const completeNew = (node: New): CompletionItem[] => | |||
| const availableForImport = (node: Node) => (node.is(Class) || node.is(Singleton) || node.is(Reference) || node.is(Mixin)) && node.name && (node as Entity).fullyQualifiedName && !implicitImport(node) | |||
|
|
|||
| const completeImports = (node: Import) => (node.environment.descendants.filter(availableForImport) as Entity[]).map(entityCompletionItem) | |||
|
|
|||
| const completeAllSigletons = (originNode: Node) => (originNode.environment.descendants.filter(node => node.is(Singleton) && !node.isClosure()) as Singleton[]).map(withImport(singletonCompletionItem)(originNode)) | |||
There was a problem hiding this comment.
A futuro podríamos tener un helper en wollok-ts que nos de allSingletons para un environment
There was a problem hiding this comment.
Sii, y tambien allWKOs
There was a problem hiding this comment.
Debería ser allGlobals y contemplar también las const globales.
Tal vez estaría bueno un método Node.isGlobal 🤔
|
Dejo un mini ejemplo de como quedo! 
Screen.Recording.2024-05-28.at.12.58.34.AM.mov |
| @@ -82,3 +88,5 @@ const completeNew = (node: New): CompletionItem[] => | |||
| const availableForImport = (node: Node) => (node.is(Class) || node.is(Singleton) || node.is(Reference) || node.is(Mixin)) && node.name && (node as Entity).fullyQualifiedName && !implicitImport(node) | |||
|
|
|||
| const completeImports = (node: Import) => (node.environment.descendants.filter(availableForImport) as Entity[]).map(entityCompletionItem) | |||
|
|
|||
| const completeAllSigletons = (originNode: Node) => (originNode.environment.descendants.filter(node => node.is(Singleton) && !node.isClosure()) as Singleton[]).map(withImport(singletonCompletionItem)(originNode)) | |||
There was a problem hiding this comment.
Debería ser allGlobals y contemplar también las const globales.
Tal vez estaría bueno un método Node.isGlobal 🤔
| ): Node { | ||
| ): Node | undefined { |
fix #155
assert.equals(analizar el contexto