fix: ignore case for type equivalence

uptrace · Oct 27, 2024 · c3253a5 · c3253a5
1 parent 3cfd8c6
commit c3253a5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/dialect/pgdialect/sqltype.go b/dialect/pgdialect/sqltype.go
@@ -126,12 +126,12 @@ var (
 )
 
 func (d *Dialect) EquivalentType(col1, col2 sqlschema.Column) bool {
-	if col1.SQLType == col2.SQLType {
+	typ1, typ2 := strings.ToUpper(col1.SQLType), strings.ToUpper(col2.SQLType)
+
+	if typ1 == typ2 {
 		return checkVarcharLen(col1, col2, d.DefaultVarcharLen())
 	}
 
-	typ1, typ2 := strings.ToUpper(col1.SQLType), strings.ToUpper(col2.SQLType)
-
 	switch {
 	case char.IsAlias(typ1) && char.IsAlias(typ2):
 		return checkVarcharLen(col1, col2, d.DefaultVarcharLen())

diff --git a/dialect/pgdialect/sqltype_test.go b/dialect/pgdialect/sqltype_test.go
@@ -16,7 +16,8 @@ func TestInspectorDialect_EquivalentType(t *testing.T) {
 			typ1, typ2 string
 			want       bool
 		}{
-			{"text", "text", true}, // identical types
+			{"text", "text", true},     // identical types
+			{"bigint", "BIGINT", true}, // case-insensitive
 
 			{sqltype.VarChar, pgTypeVarchar, true},
 			{sqltype.VarChar, pgTypeCharacterVarying, true},