-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CodeQL workflow for GitHub code scanning #95
base: master
Are you sure you want to change the base?
Conversation
We don't maintain or care about those other branches. Signed-off-by: Patti Vacek <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
=======================================
Coverage 84.46% 84.46%
=======================================
Files 172 172
Lines 12284 12284
=======================================
Hits 10376 10376
Misses 1908 1908
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CodeQL failures are mostly in the tests/test fixtures. I wonder whether we should fix it or just turn the codeql check for the tests at all.
I like the idea, but I think we should get all the checks green (or disable the troublesome ones) before merging. The error appears to be with setting up the build environment: |
Valid question. Typically we've been less strict about the tests, and I'm okay with that continuing to be the case.
100% agree. I haven't had time to really dig into this but I figured putting it up was better than nothing. |
See advancedtelematic/aktualizr#1830.