Merge pull request #66 from swipely/option-to-not-add-startup

Add option to not add startup script
upserve · Jun 4, 2015 · f4d7a32 · f4d7a32
2 parents a50bd94 + 159abb9
commit f4d7a32
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 6 deletions.
diff --git a/lib/dockly/deb.rb b/lib/dockly/deb.rb
@@ -7,7 +7,8 @@ class Dockly::Deb
   logger_prefix '[dockly deb]'
   dsl_attribute :package_name, :version, :release, :arch, :build_dir,
                 :deb_build_dir, :pre_install, :post_install, :pre_uninstall,
-                :post_uninstall, :s3_bucket, :files, :app_user, :vendor
+                :post_uninstall, :s3_bucket, :files, :app_user, :vendor,
+                :package_startup_script
 
   dsl_class_attribute :docker, Dockly::Docker
   dsl_class_attribute :foreman, Dockly::Foreman, type: Array
@@ -20,6 +21,7 @@ class Dockly::Deb
   default_value :files, []
   default_value :app_user, 'nobody'
   default_value :vendor, 'Dockly'
+  default_value :package_startup_script, true
 
   def file(source, destination)
     @files << { :source => source, :destination => destination }
@@ -102,7 +104,7 @@ def build_package
     add_files(@dir_package)
     add_docker_auth_config(@dir_package)
     add_docker(@dir_package)
-    add_startup_script(@dir_package)
+    add_startup_script(@dir_package) if package_startup_script
 
     convert_package
 

diff --git a/spec/dockly/deb_spec.rb b/spec/dockly/deb_spec.rb
@@ -64,7 +64,7 @@
           name 'deb_test'
           import 'https://s3.amazonaws.com/swipely-pub/docker-export-ubuntu-latest.tgz'
           git_archive '.'
-          build 'touch /deb_worked'
+          build 'RUN touch /deb_worked'
           build_dir 'build/docker'
         end
       end
@@ -89,7 +89,7 @@
           name 'deb_test'
           import 'https://s3.amazonaws.com/swipely-pub/docker-export-ubuntu-latest.tgz'
           git_archive '.'
-          build 'touch /deb_worked'
+          build 'RUN touch /deb_worked'
           build_dir 'build/docker'
 
           registry :test_docker_registry do
@@ -166,6 +166,15 @@
       subject.create_package!
       expect(`dpkg --contents #{filename}`).to include("dockly-startup.sh")
     end
+
+    context 'when package_startup_script is false' do
+      before { subject.package_startup_script(false) }
+
+      it 'does not place a startup script in the package' do
+        subject.create_package!
+        expect(`dpkg --contents #{filename}`).to_not include("dockly-startup.sh")
+      end
+    end
   end
 
   describe '#exists?' do

diff --git a/spec/dockly/rpm_spec.rb b/spec/dockly/rpm_spec.rb
@@ -51,7 +51,7 @@
           name 'rpm_test'
           import 'https://s3.amazonaws.com/swipely-pub/docker-export-ubuntu-latest.tgz'
           git_archive '.'
-          build 'touch /rpm_worked'
+          build 'RUN touch /rpm_worked'
           build_dir 'build/docker'
         end
       end
@@ -76,7 +76,7 @@
           name 'rpm_test'
           import 'https://s3.amazonaws.com/swipely-pub/docker-export-ubuntu-latest.tgz'
           git_archive '.'
-          build 'touch /rpm_worked'
+          build 'RUN touch /rpm_worked'
           build_dir 'build/docker'
 
           registry :test_docker_registry do
@@ -153,6 +153,15 @@
       subject.create_package!
       expect(`rpm -qpl #{filename}`).to include("dockly-startup.sh")
     end
+
+    context 'when package_startup_script is false' do
+      before { subject.package_startup_script(false) }
+
+      it 'does not place a startup script in the package' do
+        subject.create_package!
+        expect(`rpm -qpl #{filename}`).to_not include("dockly-startup.sh")
+      end
+    end
   end
 
   describe '#exists?' do