Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exclusions when ignoring files #541

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle exclusions when ignoring files #541

wants to merge 1 commit into from

Conversation

ghostsquad
Copy link

Always exclude Dockerfile and .dockerignore from being ignored.

https://docs.docker.com/engine/reference/builder/#dockerignore-file

You can even use the .dockerignore file to exclude the Dockerfile and .dockerignore files.
These files are still sent to the daemon because it needs them to do its job.
But the ADD and COPY instructions do not copy them to the image.

resolves #484

Always exclude Dockerfile and .dockerignore from being ignored.

https://docs.docker.com/engine/reference/builder/#dockerignore-file
> You can even use the .dockerignore file to exclude the Dockerfile and .dockerignore files.
> These files are still sent to the daemon because it needs them to do its job.
> But the ADD and COPY instructions do not copy them to the image.

resolves #484
@kiela
Copy link

kiela commented May 29, 2019

@tlunter Any chance to get it merged in?

@ianfixes
Copy link
Contributor

ianfixes commented Jun 8, 2021

What does this PR need in order to be accepted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build_from_dir can't find Dockerfile when .dockerignore is "*"
3 participants