Update to remote api v1.12 #431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tlunter If this was rebased would you entertain merging it. I'd really like to get this gem to an API version supported on the Windows client, which this PR accomplishes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at exposing new docker 1.12 features. #423
This contains no automated tests (although I did basic manual testing) due to the desire to have #429 merged before adding sufficient automated tests. I will add those once everything is all merged up.
Some of the implementation is copy pasted from other classes that are already in the gem, some my own thoughts.
If this change and #429 are acceptable, then I would like to explore some other refactoring including some superclass design, as well as refactoring with extract method.
Thanks again for this excellent tool in our toolbox!