-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excon v0.111.0 has broken this gem #586
Comments
not nice to see this in our production env impacting 1000s of hosts today. How can we prevent this from happening in the future? |
Invest in a CI setup and don't pull random updates into production? |
Chef automatically installs latest gem(s) that meet defined dependencies on each run. The only way to stop this would be to make sure it uses the Bundler flag I suspect Puppet users are in the same situation. The only other way this could have been avoided would be for To work around it I had to modify the docker cookbook to pull the gem from my own rubygems server (geminabox) and build/upload a copy of "docker-api-2.2.1" from the Completely insane behavior all around, really. |
Fix #586: require newer excon, use valid parameter keys interface
Hi folks, released v2.3.0 which should fix this error. |
Sorry to hear about this impact (I'm the author of excon). I hadn't seen any reason to believe this freeze would have this kind of impact since the excon test suite otherwise was not impacted by it. This may speak to the hijack middleware being somewhat unusual compared to other things and was doing something that was not expected. In any event, I'm glad you were able to find the fix quickly and feel free to reach out if you have issues or concerns in the future. |
No worries @geemus, definitely our fault on this end for not updating to the proper interface. |
Easy to overlook I'm sure, glad it was an easy fix. |
@ls-todd-lunter, do you mean to add a |
@b-dean sorry, yes. Pushed the tag now. |
* 'master' of https://github.com/upserve/docker-api: Minor version bump Mark as pending broken test for Docker 27 Don't fail fast, allow for re-runs that will likely succeed Fix broken tests, add sleep to allow container to die after kill signal Fix some broken tests or mark as pending Update build config Fix upserve#586: require newer excon, use valid parameter keys interface
I've bumped the version of the `docker-api` gem as per [this issue](upserve/docker-api#586) and that seems to addresses the [CI failure](https://github.com/lawrencegripper/azbrowse/actions/runs/10150688701/job/28068348472?pr=579#step:5:1013)
The
VALID_REQUEST_KEYS
constant is now frozen so aFrozenError
is thrown whenrequire
ing this gem.https://github.com/excon/excon/blame/master/lib/excon/constants.rb#L66
The text was updated successfully, but these errors were encountered: