feat: Add custom webhook as notification option #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 FYI |
AnandChowdhary
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Perhaps it makes sense to rename NOTIFICATION_WEBHOOK to NOTIFICATION_CUSTOM_WEBHOOK?
For example, for Microsoft Teams we have:
NOTIFICATION_TEAMSNOTIFICATION_TEAMS_WEBHOOK_URL
So maybe we can make it clear that it's a custom webhook rather than a service webhook?
|
Can you also please add docs to https://github.com/upptime/upptime.js.org/blob/master/docs/notifications.md and I can merge them at the same time? Thanks a lot for your hard work on this! |
Co-authored-by: Anand Chowdhary <[email protected]>
Co-authored-by: Anand Chowdhary <[email protected]>
|
@AnandChowdhary And thanks for the quick response |
|
🎉 This PR is included in version 1.38.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the support of custom webhooks as notification endpoint
This would be the first step to solve upptime discussions 191
It uses
NOTIFICATION_WEBHOOKboolean andNOTIFICATION_WEBHOOK_URLfor the URLOther configuration could be possible when this PR gets merged.
Thanks ✌️