Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for pinging IPv6 addresses and hostnames via ipv6: true #231

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

titanism
Copy link
Contributor

@titanism titanism commented Dec 9, 2023

@titanism
Copy link
Contributor Author

titanism commented Dec 9, 2023

@AnandChowdhary can you please merge and release #231 to npm?

titanism added a commit to forwardemail/status.forwardemail.net that referenced this pull request Dec 9, 2023
@AnandChowdhary AnandChowdhary merged commit fcebd9e into upptime:master Dec 10, 2023
@AnandChowdhary
Copy link
Member

Thanks @titanism (also saw your email). Can you also please document the ipv6: true property in the documentation repository upptime/upptime.js.org? Thanks again!

titanism added a commit to titanism/upptime.js.org that referenced this pull request Dec 13, 2023
@titanism
Copy link
Contributor Author

@AnandChowdhary done! can you merge upptime/upptime.js.org#48 and then release to npm? Thank you 🙏

@upptime-bot
Copy link
Member

🎉 This PR is included in version 1.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@titanism
Copy link
Contributor Author

@AnandChowdhary Thank you, but unfortunately your code rewrite broke our original PR 😦

You can see your code here

if (isIP(url)) {
if (site.ipv6 && !isIPv6(url))
throw new Error("Site URL must be IPv6 for ipv6 check");
else if (site.ipv6)
address = (await dns.promises.resolve6(url))[0];
else
address = (await dns.promises.resolve4(url))[0];
if (isIP(url) && !isIP(address))
throw new Error("Site IP address could not be resolved");
}
vs our original PR fcebd9e#diff-0dd1092b99d3bb57c98957de5ec7d4f502b3470e49f3442d152980e40deb0a60R161-R173.

We've submitted another PR to resolve this, can you please merge and release to npm?

Thank you 🙏

titanism added a commit to titanism/uptime-monitor that referenced this pull request Dec 13, 2023
It appears your rewrite caused this feature to not work.

See our comment here <upptime#231 (comment)>.
@titanism
Copy link
Contributor Author

@AnandChowdhary #232

AnandChowdhary pushed a commit that referenced this pull request Dec 13, 2023
It appears your rewrite caused this feature to not work.

See our comment here <#231 (comment)>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants