-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for pinging IPv6 addresses and hostnames via ipv6: true
#231
Conversation
@AnandChowdhary can you please merge and release #231 to npm? |
Thanks @titanism (also saw your email). Can you also please document the |
@AnandChowdhary done! can you merge upptime/upptime.js.org#48 and then release to npm? Thank you 🙏 |
🎉 This PR is included in version 1.34.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@AnandChowdhary Thank you, but unfortunately your code rewrite broke our original PR 😦 You can see your code here Lines 160 to 170 in 1999eda
We've submitted another PR to resolve this, can you please merge and release to npm? Thank you 🙏 |
It appears your rewrite caused this feature to not work. See our comment here <upptime#231 (comment)>.
It appears your rewrite caused this feature to not work. See our comment here <#231 (comment)>.
Per upptime/upptime#888