Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proposal] Better key and DID import #680

Closed
RobertoSnap opened this issue Aug 26, 2021 · 1 comment · Fixed by #661
Closed

[proposal] Better key and DID import #680

RobertoSnap opened this issue Aug 26, 2021 · 1 comment · Fixed by #661
Assignees
@mirceanis
Labels
enhancement New feature or request

Comments

@RobertoSnap
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I feel on shaky grounds when importing keys (with DID) into Veramo. I dont know if i do it correctly and getting the keys with all information needed is a hassle.

Describe the solution you'd like
A function that takes PK and maybe keytype (if it cant be derived).

Describe alternatives you've considered
Currently we are saving all key and DID info in .evn variables then doing an import of those if we dont find those keys into the database. We are also trying to make sure we are only running on set of keys on the agent (running on a server).

Additional context

26-08-2021 at 08 26 09
@RobertoSnap RobertoSnap added the enhancement New feature or request label Aug 26, 2021
@mirceanis
Copy link
Member

Great proposal!
We're already on it. This is going to be solved in #661

@mirceanis mirceanis mentioned this issue Aug 26, 2021
Merged
@mirceanis mirceanis self-assigned this Aug 26, 2021
mirceanis added a commit that referenced this issue Sep 1, 2021
@mirceanis
feat(key-manager): move private key storage to kms-local (#661)
6b1d135 
BREAKING CHANGE: `keyManagetGet` no longer returns private key data
BREAKING CHANGE: `KeyStore` no longer requires a `SecretBox`
BREAKING CHANGE: `KeyManagementSystem` needs a `PrivateKeyStore`
BREAKING CHANGE: @veramo/cli configuration version update to 3.0

If you're already working with Veramo and wish to upgrade existing agents to veramo 3.0, you'll have to make some changes to your configuration, depending on how you're using the framework.

It boils down to these 3 steps:

1. Update your database connection to use migrations
2. Remove the `SecretBox` parameter from `KeyManager`
3. Add a `PrivateKeyStore` parameter to `KeyManagementSystem` with a `SecretBox` that you were using before with `KeyManager` (and keep the same encryption key)

* feat(key-manager): move private key storage to kms-local

fixes #539
fixes #540
fixes #680

* feat(data-store): add migration of key stores

* fix(data-store): fix usage of where clause for queries

* refactor(kms-local): simplify constructor for KeyManagementSystem

* style: remove scar tissue and unused code
@mirceanis mirceanis mentioned this issue Sep 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirceanis mirceanis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(key-manager): move private key storage to kms-local decentralized-identity/veramo
2 participants
@mirceanis @RobertoSnap