-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(key-manager): move private key storage to kms-local #661
Conversation
9bd943f
to
a1401c3
Compare
Codecov Report
@@ Coverage Diff @@
## next #661 +/- ##
===========================================
+ Coverage 67.58% 79.19% +11.61%
===========================================
Files 62 85 +23
Lines 1530 2591 +1061
Branches 247 439 +192
===========================================
+ Hits 1034 2052 +1018
- Misses 400 537 +137
+ Partials 96 2 -94 |
a1401c3
to
6803fab
Compare
6803fab
to
c1226cb
Compare
c1226cb
to
aa10fce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @mirceanis !
What's new
@veramo/key-manager
no longer holds private key material@veramo/kms-local
gets its ownPrivateKeyStore
How to upgrade
If you're already working with Veramo and wish to upgrade existing agents to veramo 3.0, you'll have to make some changes to your configuration, depending on how you're using the framework.
It boils down to these 3 steps:
migrations
SecretBox
parameter fromKeyManager
PrivateKeyStore
parameter toKeyManagementSystem
with aSecretBox
that you were using before withKeyManager
(and keep the same encryption key)Typescript app config changes
If your agents are part of a typescript app, these changes will look like this:
CLI config changes
fixes #539
fixes #540
fixes #680
BREAKING CHANGE:
keyManagetGet
no longer returns private key dataBREAKING CHANGE:
KeyStore
no longer requires aSecretBox
BREAKING CHANGE:
KeyManagementSystem
needs aPrivateKeyStore
BREAKING CHANGE: @veramo/cli configuration version update to 3.0